Conversation
- Created `math_explorer_gui/src/tabs/clinical_trials/randomization.rs` with `RandomizationTool`.
- Implemented Strategy pattern via `ClinicalTrialsTool` to add it to `ClinicalTrialsTab`.
- Leveraged `math_explorer::applied::clinical_trials::design::{SimpleRandomizer, BlockRandomizer}`.
- Updated `todo_gui.md` to mark Randomization feature and `4.2 Clinical Trials` section as complete.
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
fderuiter
deleted the
clinical-trials-randomization-tool-15019054644524073895
branch
There was a problem hiding this comment.
Pull request overview
Adds the missing Randomization tool to the Clinical Trials tab in math_explorer_gui, leveraging the existing math_explorer clinical trials randomization strategies.
Changes:
- Implemented a new
RandomizationTool(simple + block randomization) as aClinicalTrialsTool. - Wired the new tool into the Clinical Trials tab tool selector.
- Marked the Clinical Trials roadmap item as implemented in
todo_gui.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| todo_gui.md | Marks Clinical Trials Randomization as implemented in the GUI roadmap. |
| math_explorer_gui/src/tabs/clinical_trials/randomization.rs | New GUI tool implementing interactive subject allocation using core randomizers. |
| math_explorer_gui/src/tabs/clinical_trials/mod.rs | Registers the Randomization tool in the Clinical Trials tab. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if self.randomization_type == RandomizationType::Block { | ||
| ui.horizontal(|ui| { | ||
| ui.label("Block Size:"); | ||
| ui.add(egui::DragValue::new(&mut self.block_size).range(2..=100)); |
| @@ -0,0 +1,132 @@ | |||
| use crate::tabs::clinical_trials::ClinicalTrialsTool; | |||
As "The Glassblower", I've added the missing Randomization tool to the
math_explorer_gui's Clinical Trials tab.Implementation details:
todo_gui.md.ClinicalTrialsTooltrait in a new struct,RandomizationTool, defined in its own file (randomization.rs).SimpleRandomizerandBlockRandomizerfrom the core librarymath_explorer, preventing any mathematical logic duplication.matchand properly handlingResults instead of usingunwrap(). Errors are gracefully shown directly in the UI.This completes the 4.2 Clinical Trials roadmap module.
PR created automatically by Jules for task 15019054644524073895 started by @fderuiter